[wpical] Remove absolute path in generated minimath file - #9389
Merged
PeterJohnson merged 1 commit intoSep 7, 2026
Conversation
github-actions
Bot
added
build
Gold856
force-pushed
the
remove-absolute-path-in-minimath
branch
from
September 6, 2026 03:17
ea116f8 to
f846169
Compare
auscompgeek
reviewed
Sep 6, 2026
| use List::Util qw(min); | ||
| use List::MoreUtils qw(pairwise); | ||
|
|
||
| say "// THIS IS AUTO-GENERATED BY $0. DO NOT EDIT BY HAND\n"; |
Member
There was a problem hiding this comment.
So… $0 should be the literal argv[0]. We could run this script by relative path rather than by the absolute path we currently use, which should avoid the problem without requiring a patch?
Gold856
force-pushed
the
remove-absolute-path-in-minimath
branch
from
September 6, 2026 21:19
f846169 to
8db3779
Compare
github-actions
Bot
removed
the
build
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8db3779984
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Gold856
force-pushed
the
remove-absolute-path-in-minimath
branch
from
September 7, 2026 06:06
8db3779 to
76a8d11
Compare
auscompgeek
reviewed
Sep 7, 2026
Gold856
force-pushed
the
remove-absolute-path-in-minimath
branch
from
September 7, 2026 07:22
76a8d11 to
2eb7f8e
Compare
auscompgeek
approved these changes
Sep 7, 2026
PeterJohnson
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues where running the script at a different location changes the file unnecessarily.